Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract translations from frontend-app-ora #7445

Merged

Conversation

nsprenkle
Copy link
Contributor

Add frontend-app-ora to list of MFEs with openedx-translation-managed translations.

@brian-smith-tcril
Copy link
Contributor

Thank you so much for this PR! Would you be able to verify the change to extract-translations-source-files is working on your fork? If you have actions enabled on your fork you should be able to visit https://github.com/nsprenkle/openedx-translations/actions/workflows/extract-translation-source-files.yml and see a workflow_dispatch trigger

image

@nsprenkle
Copy link
Contributor Author

Thank you so much for this PR! Would you be able to verify the change to extract-translations-source-files is working on your fork? If you have actions enabled on your fork you should be able to visit https://github.com/nsprenkle/openedx-translations/actions/workflows/extract-translation-source-files.yml and see a workflow_dispatch trigger

image

Hey @brian-smith-tcril , none of the workflows here transferred over to my fork. Is there a standard process to get these set up?

@nsprenkle
Copy link
Contributor Author

nsprenkle commented Nov 21, 2024

Okay, @brian-smith-tcril , I did a bit of research and troubleshooting but figured it out. Capturing what I found here for folks who may run into something similar.

  1. GitHub actions (by default) only run on main/`master. I had to merge my changes into main to get the workflows to show up.
  2. I had to modify the .github/workflows/extract-translation-source-files.yml file (see nsprenkle@67d4a9e) to get the runner to pick up from the openedx org instead of my personal account.

After those, I was then able to ✅ successfully run the workflow creating these files on this new branch .

My question: is success in running that job all that is needed for verification?

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for writing up the changes you needed to make to verify it on your fork! It looks like the generated file is valid and the path matches the one you added to transifex.yml so this should be good to go!

@nsprenkle
Copy link
Contributor Author

Thank you so much for writing up the changes you needed to make to verify it on your fork! It looks like the generated file is valid and the path matches the one you added to transifex.yml so this should be good to go!

Excellent, thanks for checking back in, @brian-smith-tcril.

I'm unable to merge so are you able to merge this PR?

@brian-smith-tcril brian-smith-tcril merged commit 133cea9 into openedx:main Nov 21, 2024
5 checks passed
@nsprenkle nsprenkle deleted the add-frontend-app-ora-translations branch November 22, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants